Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the xhydro recipe #27831

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add the xhydro recipe #27831

wants to merge 8 commits into from

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Oct 9, 2024 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/xhydro/meta.yaml) and found it was in an excellent condition.

@Zeitsperre
Copy link
Contributor Author

@TC-FF @RondeauG @sebastienlanglois

Please let me know in a comment here if you'd like to be (or not be) a maintainer on this package. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/xhydro/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: TC-FF, SebastienLanglois. Please ask them to comment on this PR if they are.

@RondeauG
Copy link

RondeauG commented Oct 9, 2024

I agree to be maintainer.

1 similar comment
@sebastienlanglois
Copy link

I agree to be maintainer.

@github-actions GitHub Actions
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@Zeitsperre
Copy link
Contributor Author

@RondeauG and @sebastienlanglois

The package could benefit from fixes to its testing suite before being merged. These are all being progressively rolled out. Perhaps we can release a patch with these fixes as the first candidate for conda-forge?

I'll keep this PR open and update it once we have a v0.4.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zeitsperre @conda-forge-admin @RondeauG @sebastienlanglois